search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.14k stars 1.41k forks source link

ContactEmail Issues Based on Language Settings #5262

Open issac527 opened 2 years ago

issac527 commented 2 years ago

Description ContactEmail values are not displayed properly when the language is Korean or French

To Reproduce Steps to reproduce the behavior:

  1. Proceed on the assumption that the language is set to Korean.
  2. bottom tool '더보기(More)' > '(방 닫기)Close Room'
  3. screen confirmation image
  4. My e-mail doesn't print out, but it seems that the variable name(?) is printed out.

Expected behavior My e-mail doesn't print out, but it seems that the variable name(?) is printed out.

Screenshots [Language: ko] image [Language: en] image

Hardware

Solution plan hubs in src/react-components/room/ExitedRoomScreen.js It seems to be a screen that is output through the file.

The defaultMessage output is good, but if the language is set separately, such as ko, fr, or de, the desired result is not produced.

Should I correct the part that calls contactEmail? Anyway, we need to check this part.

matthewbcool commented 2 years ago

Thanks for your investigation and excellent report around this issue.

I was able to confirm that the issue is not related to settings in the admin panel of hubs.mozilla.com and it's also reproducible on hubs cloud.

Confirmed issue with ko, de and fr. (when we are using translation strings with contactEmail)

Please do make the correction, welcome this PR.