search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.41k forks source link

Workflow turkeyGitops/ build failure #5430

Open Adi-FHE opened 2 years ago

Adi-FHE commented 2 years ago

Discussed in https://github.com/mozilla/hubs/discussions/5429

Originally posted by **Adi-FHE** May 13, 2022 I am currently trying to create new branch in forked repository of mozilla/hubs. This branch would be merged with `(mozilla/hubs) upstream/hubs-cloud` and `(forked) origin/my-customHubs (Our custom feature)`. Whenever I pushed my local changes in newly created branch into origin (forked) remote with `git push origin mybranch `, following docker login error` (workflow error in turkeyGitops/build)` ensue. I still can do access and manipulate the branch in my forked repository and the local hubs client also running as expected. My only concern is this workflow Error, which discourage me from uploading the branch to my live server. If anyone kind enough to enlighten or point me to the right direction on why this problem occurs, i would really thankful. ![bd6f54ddab675ae7ab0cfd84c6e12029](https://user-images.githubusercontent.com/32239509/168259175-03883782-4f45-451d-a2ca-42c6e1a462ea.png)
wmurphyrd commented 2 years ago

Same here, recommend to alter the github workflow config to only run these on the main repo.

You can use an if on the job with some github-provided variables like repo owner, e.g what was done here https://github.com/prisma/prisma/issues/3539

If you'd accept a PR for this, I will make one

brianpeiris commented 2 years ago

Sounds right to make the workflow conditional based on the repo owner. Tagging @tanfarming for visibility.