search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.41k forks source link

Links lead to wrong room #6090

Open jywarren opened 1 year ago

jywarren commented 1 year ago

Description A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to a room via URL, i.e. https://hubs.mozilla.com/xxxx/xxxx (the room is private, sorry)
  2. See the contents of a different room (albeit one which shares the same scene)

Multiple people in the workshop experienced this.

Expected behavior

I expected to see the correct room.

Screenshots If applicable, add screenshots to help explain your problem.

Hardware

Additional context Add any other context about the problem here.

jywarren commented 1 year ago

We were also generally having a lot of issues freezing, having to reload. We have about 500 objects (some in the scene, some media objects added in the room). I wonder if we're pushing the limits there?

matthewbcool commented 1 year ago

assuming all those objects have their own textures then that would be many times over the recommended texture limit in spoke.

Outside of that though, if the rooms have different pinned objects and the same scene this is likely a bug related to fast room switching. Possible relates to https://github.com/mozilla/hubs/issues/5729

We should come back to this after bitECS goes live and see if we can reproduce. As always, thanks for the report!

jywarren commented 1 year ago

Ah no - many share the same texture (are clones). But I had used this space and ones with similar # of objects pretty often without issue before (regarding the freezing issue). We briefly got a 503 error as well, so I thought perhaps there was a throughput or load issue on one of the servers. But really it's a separate issue from the "wrong room" issue.

Thanks!! - bitECS is going live in the next week or so, right?

jywarren commented 1 year ago

Actually even now I can't seem to get to the correct room. Is there any recommendation for... like making an in-room link back to the right room to try to reset the fast room switching?

jywarren commented 1 year ago

I tried pasting the correct URL in, and the button doesn't work to join that room... presumably because it's checked against the current URL and it matches (even though we're not actually in the other room).

Yes -- Change hub called with the current hub id. This is a noop.

Just for added detail. Tx!

jywarren commented 1 year ago

I'll try an empty cache and reload, as well.

... that didn't work. Here's a log output from page refresh after emptying cache:

https://gist.github.com/jywarren/3db849fbef65d5db15a9ef1b1ffcbf73

jywarren commented 1 year ago

Could also be related to:

We were heavily using deep links like https://hubs.mozilla.com/xxxx/xxxx#Waypoint - could be an issue.