search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.14k stars 1.41k forks source link

User-added objects persist into other rooms #6103

Open minim-sheba opened 1 year ago

minim-sheba commented 1 year ago

Description Adding objects to a room where this is permitted results in those same objects being visible in rooms visited afterwards, including those where there are no permissions to add objects. Shift-refresh on a page that has objects from elsewhere forces check-in to the page, which seems to clear the objects, but if I revisit the object-laden page afterwards, pinned objects from there can then be seen on the page that was force-refreshed when I click back through (clicking on a link, not back in the browser, that is). While most of these persisting objects were added today, some (e.g. in the URLs given in the steps below, the bald man gif and the winged horse thing) have been present for many months, and not all items seem to be persisting (in my examples, the Aardman penguin gif is one of these. I'm not sure how long it's been in the space for). However, going back to the object-laden page seems to add another persisting copy of the objects which then persists into the other rooms - mostly this looks the same but animated objects running at slightly different rates show the duplication (e.g. the animated x-wing model in my example)

Unpinned objects added today have also been seen to be persisting into other rooms, although these seem to have vanished as expected on revisiting the space where they were pinned, and they haven't reappeared since in the other rooms.

I first observed this behaviour in Chrome (Win11) in a session with several colleagues who were on an assortment of desktop/laptop Mac/Win devices, all of whom reported seeing the same things. I have since tested also in Firefox (both logged in and logged out), where I found the same behaviour.

To Reproduce Steps to reproduce the behavior:

  1. Go to Haydn Space Opera - The Warm-Up Room - this is a fairly open space with a few videos and gateways to other rooms (screenshot 1)
  2. Click on the link in the 'This way to The Blank Page' gateway. This opens a room with a variety of odd objects (that are meant to be here and meant to be odd!) (screenshot 2)
  3. Turn around and click through the gateway behind you to go back to The Warm-Up Room (on one occasion this did not create the persistence for me, but repeating 2 and 3 did trigger it)
  4. The Warm-Up Room is now populated with giant ducks, x-wing, cat gif, etc. as well as the materials that were in here originally (screenshot 3).
  5. Repeat steps 2 and 3 to view duplicated items - you can see this with how the animated x-wing model has quadruple wings instead of double ones (screenshot 4)
  6. Moving to any of the other rooms (via the Warm-Up Room gateways) shows the same objects (including any duplication) persisting into these other spaces - The Apocalypse probably shows this most clearly (screenshot 5)

Expected behavior Objects added in one room are not seen in other rooms, whether pinned or not.

Screenshots

  1. The Warm-Up Room on first entering after a shift-refresh (how it's supposed to look and has looked since 2021) - 1 fresh entry into warm-up room_2023-05-26_22-16-12
  2. The Blank Page, showing a random assortment of objects that have been added to it over time - 2 visit the blank page_2023-05-26_22-17-05
  3. The Warm-Up Room (WUR) after clicking back from The Blank Page (TBP), now showing the same objects as were seen in TBP alongside the original WUR objects - 3 blank page objects now visible in warm-up room_2023-05-26_22-18-13
  4. The x-wing model from TBP in the WUR after a second visit to TBP - note the 4 prongs(?) to each wing which normally only has 2 - in the room the different rates of animation very clearly show that the object has been duplicated - 4 doubled x-wing in warm-up room_2023-05-26_22-38-09
  5. All the persisting objects, seen from a distance in The Apocalypse, including the animated x-wing showing duplication - 5 persisting objects incl doubled x-wing in the apocalypse_2023-05-26_22-56-19

Hardware

Additional context This set of rooms was originally created in 2020, and all of the rooms accessible from The Warm-Up Room were completed in 2021. Thus this is a legacy site, but this seems to be new behaviour. Of the rooms accessible through The Warm-Up Room's gateways, only The Blank Page gives permission to add and pin objects.

The issue was discovered when visiting a new room which I am creating (not yet accessible from the Warm-Up Room, but links through to it) with 5 colleagues from my research group today. The new room (The Corridor - https://hubs.mozilla.com/JdK7boq/hso-corridor ) is currently very media-heavy, but entirely populated from within Spoke rather than adding things in Hubs. We first noticed this persistence problem when passing from The Corridor to The Warm-Up Room where some small (unpinned) ducks that had been placed by a colleague to show me which videos weren't loading for him were spotted sitting just beyond the edge of one side of the main Warm-Up Room Area - they then showed up for all of us in all the other rooms we visited.

Thanks for your help!

matthewbcool commented 1 year ago

Thanks for the detailed and helpful report! I was able to reproduce it on a macbook in Chrome.

Maybe a milestone could be made of all fast room switching-related issues for review once the new loader is in place.

6090

5729

5559

5382

5007

4928

4832

Recommend re-testing all the above following the completion of #5899