search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

Fix aframe media loading #6413

Closed keianhzo closed 9 months ago

keianhzo commented 9 months ago

After changing the media loader to keep the MediaLoader component and have MediaLoading to trigger the loading process we should have removed the MediaLoading component from the aframe media-loader ortherwise it triggers a media load from the bitecs media loader.

This PR removes the MediaLoading from the aframe media loader and changes the media frames to ignore entities that don't have the MediaContentBounds component and treat them as loading entities as MediaContentBounds is only added when the media has been fully loaded.