Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

BG - `Get Material Property` returns `undefined` or `NaN` #6417

Closed j-conrad closed 9 months ago

j-conrad commented 9 months ago

Description When attempting to use the Get Material Property node, the debug output returns undefined or NaN.

image

To Reproduce Steps to reproduce the behavior:

  1. Make an On Interact node that triggers a Debug Log
  2. Attach a Get Material Property to the debug and try various parameters like Opacity or Roughness
  3. Run in Hubs
  4. Note the debug returns undefined values.

Expected behavior It should return the proper parameter value

Hardware

keianhzo commented 9 months ago

It was a silly bug when writing the node value. Fixed here: https://github.com/mozilla/hubs/commit/a6f81a801177ef68f703fdfdd5d8632b54fa6fba