Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

bitECS: Right clicking on a camera to rotate it causes it to be focused on as well #6420

Open Exairnous opened 9 months ago

Exairnous commented 9 months ago

Description When attempting to rotate an in-room camera with the right mouse button in the new loader the camera is rotated, but also focused on as well. This provides a jarring experience, especially when attempting to flip the camera by just quickly right clicking, instead of right clicking and dragging. The AFrame/old loader does not focus on the camera.

To Reproduce Steps to reproduce the behavior:

  1. Go to a room with the new loader enabled.
  2. Spawn a camera.
  3. Right click (or right click and drag) on the camera to flip/rotate it.
  4. See that the camera is focused on as well as flipped/rotated.

Expected behavior This is a little tricky, originally the camera was rotated like any other object, not by right click, and could be focused on by either pressing F or right clicking, but ever since it was rebuilt in bitECS it has not had the standard object interactions, hasn't been able to be focused, and has been rotated via the right mouse button. So either of the two behaviors would be better than it is now, but ultimately I think the first behavior is what should be restored (although that's probably out of scope for this bug report).

Videos New Loader: https://github.com/mozilla/hubs/assets/9795121/5d0ef3fe-a091-468d-895b-834fcd11820c

Old Loader: https://github.com/mozilla/hubs/assets/9795121/e83a9dd1-12b9-4170-86ff-9c79debd4edf

Hardware