search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

bitECS: Image components show open link hover buttons when no links are present #6422

Open Exairnous opened 9 months ago

Exairnous commented 9 months ago

Description Adding an image component to your scene and using the new loader causes the open link hover button to be displayed even when there is no link component present (the button also doesn't do anything when clicked on).

To Reproduce Steps to reproduce the behavior:

  1. Load a scene with an image component (but no link component) into a Hubs room with the new loader.
  2. Hover your cursor over the image.
  3. See the open link button appear on hover and see that it doesn't do anything when clicked.

Expected behavior The open link hover button shouldn't appear unless there is a link on the object along with the image component.

Videos New Loader: https://github.com/mozilla/hubs/assets/9795121/63b53681-0f7b-488f-9668-01a51962c700

Old Loader: https://github.com/mozilla/hubs/assets/9795121/0fc74d69-a7f9-4187-a68b-7a437b1de007

Hardware