search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

Full-body avatar #6428

Closed hunjuly closed 8 months ago

hunjuly commented 9 months ago

GLBs for test https://github.com/belivvr/files/raw/main/male.glb https://github.com/belivvr/files/raw/main/female.glb

mikemorran commented 8 months ago

Hey @hunjuly, likely for this feature to be added, we will have to rewrite in the bitECS system to ensure reliability moving forward. Have you explored bitECS yet?

hunjuly commented 8 months ago

“The bitECS-based Hubs client is still under development and stability is not fully guaranteed. Therefore, the bitECS based client is disabled by default. We plan to enable the bitECS based client by default after safety has been sufficiently confirmed.” I saw that, but if they're making it bitECS-based now, doesn't that mean that full-body won't be available for A-frame-based clients until they change the default for rooms? I'm wondering if it's mandatory to use BitECS, which is still in development, to use new features like full-body.

mikemorran commented 8 months ago

“The bitECS-based Hubs client is still under development and stability is not fully guaranteed. Therefore, the bitECS based client is disabled by default. We plan to enable the bitECS based client by default after safety has been sufficiently confirmed.” I saw that, but if they're making it bitECS-based now, doesn't that mean that full-body won't be available for A-frame-based clients until they change the default for rooms? I'm wondering if it's mandatory to use BitECS, which is still in development, to use new features like full-body.

All of our systems and components, with a few small exceptions, are rewritten in bitECS in the new client and the feature flag toggles between those new and old versions. We aren't fully removing AFRAME, so it looks like your PR would run (although I have not looked in depth), however for maintainability we recommend bitECS.

worph commented 8 months ago

We really want this feature at. What could help push this feature into the master. Another pull request compatible with bitECS?

hunjuly commented 8 months ago

Well, I don't plan to add the feature until hubs is stable enough to make bitECS the default. My team has other, more important things to do.