Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

LiveVideo m3u8 links crash multiplayers for newLoader #6483

Open hrithikwins opened 6 months ago

hrithikwins commented 6 months ago

Description Presence of a livevideo I've used m3u8 link, due to the livevideo the person who joins later is able to join but the person who joined earlier gets his screen frozen, except they can hear the audio

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://testing.dev.myhubs.net/he63zwx/assured-timely-room' where you will see a livestream video
  2. Join from a new tab, notice that you are successfully able to join both the rooms simulataneously
  3. Now append ?newLoader in both the rooms
  4. as soon as the second person joins in the second person's livestream is paused and the first person's render is completely stopped, they cannot do anything as their screen is stuck

Expected behavior successfully able to join both the rooms simulataneously

Screenshots If applicable, add screenshots to help explain your problem.

image image

Hardware

Additional context Related to https://github.com/mozilla/hubs/commit/1f06f5338485398db1f061dd3c73095bbd702c6f as it got resolved for video but there is some problem with accessibleUrl due to which loadMedia is not getting resolved in newLoader

hrithikwins commented 6 months ago

was able to fix by going to src/bit-systems/video-system.ts to networkedVideoQuery() and adding a 'return' after getting src because src is null for hls video


      const src = APP.getString(NetworkedVideo.src[eid])!;
      console.log("the src is ", src, eid);
      return;```

 in behavior-graph-spike-rebased-2
hrithikwins commented 6 months ago

when I console.log(NetworkedVideo.src) it's an Uint8Array