search

Hubs-Foundation / reticulum

Phoenix web server for Hubs
Mozilla Public License 2.0
450 stars 181 forks source link

Whitelist/toggle rate limit on hub creation #614

Open camelgod opened 2 years ago

camelgod commented 2 years ago

Many of us use Reticulum to create rooms programmatically from one endpoint.

The rate limit here

https://github.com/mozilla/reticulum/blob/7fc356e3318f2f214acf67aec898d2c904fd7fad/lib/ret_web/controllers/api/v1/hub_controller.ex

makes it impossible to rapidly create rooms on high user demand..

Really need a IP whitelist or toggle to turn off and/or adjust the rate limiter.

yakyouk commented 1 year ago

You can work around this by checking the error code returned, 403 usually means you've been rate-limited and can retry

camelgod commented 1 year ago

You can work around this by checking the error code returned, 403 usually means you've been rate-limited and can retry

Yeah but if you have more than one or lets say hundreds of requests per second? My server would be backed up. Its not exactly scaleable unless i create multiple reticulum instances and load balance it manually. Would be nice to be able to hammer the server in any case from the same IP.