search

HubspotCommunity / hubspot-ruby

Ruby wrappers for the HubSpot REST API
https://developers.hubspot.com/docs/endpoints
MIT License
190 stars 257 forks source link

Add appraisal gem #155

Closed SViccari closed 5 years ago

SViccari commented 5 years ago

Fixes #157

Summary: Introduces Appraisal and updates activesupport to require version >= 4.2.2.

A description of Appraisal and it's purpose:

Appraisal integrates with bundler and rake to test your library against different versions of dependencies in repeatable scenarios called "appraisals." Appraisal is designed to make it easy to check for regressions in your library without interfering with day-to-day development using Bundler.

Version bump for ActiveSupport: ActiveSupport version4.2.2 includes two important security vulnerability fixes. ActiveSupport 4.1.11 also includes the same vulnerability fixes. We could support 4.1.11 but since 4.2.2 has been available since June 16, 2015, it seems reasonable to increase the required version to 4.2.2 instead of spending additional time ensuring this library supports older versions.

SViccari commented 5 years ago

@cbisnett @adimichele When you have time, I'd like your thoughts on dropping support for ActiveSupport < 4.2.2.

adimichele commented 5 years ago

Sounds good to me! Would love thoughts from @cbisnett though