Hucaru / Valhalla

A Golang MapleStory (v28) server
MIT License
274 stars 71 forks source link

[BUG] Inventory duplicate on equip #25

Closed ErwinsExpertise closed 4 years ago

ErwinsExpertise commented 4 years ago

I have noticed when either equipping an item from the inventory will allow it to be duplicated.

Steps to recreate: Obtain item Equip to character Relog

Item will then be present on avatar as well as another in the inventory. I haven't really been able to look into this much but creating an issue to log the bug. I am working on monster status/skills atm so I am not able to address this bug at this time.

Hucaru commented 4 years ago

The inventory system is a bit of a mess as I wrote it to have something there to work with when testing other systems. The whole thing needs a rewrite along with consideration of how & when database updates should occur.

Edit: the player package should probably have an inventory.go file with a struct dedicated to inventory and it's operations including saving and loading.