Closed amityahav closed 2 years ago
Don't forget to update readme
updated pr according to latest comments.
CR followup
If the changes are okay with @Hucaru, what would you be interested in working on next, @amityahav?
If the changes are okay with @Hucaru, what would you be interested in working on next, @amityahav?
I think issue #55 might be a good one to do as after that only preventing a character from being created on a world is left as a login feature.
I think issue #55 might be a good one to do as after that only preventing a character from being created on a world is left as a login feature.
Could you double check if the readme is up to date?
@ErwinsExpertise did a lot of work, but I'm unsure if Player use item (scrolls, potions etc)
and Player drop item(s)
were completely implemented in #51. There were a lot of stuff on ErwinsExpertise's plate, and Player skill logic (haste etc)
was also among them. Not sure how that's going right now, but I hope we hear back eventually.
I think the readme is missing 3 items for the login server
[ ] Show EULA on first login
[ ] Show gender select on first login
[ ] Allow world locking when full
I think the last one is managed by a single byte in the world description packet
CR follow up
Happy for me to merge?
Yes! Thanks
Hey again, i've implemented the task 'active gm command for change rates for all channels' this works for all rates with the command: /rate <exp | drop | mesos> rate rate is an int16 because its enough.
extra command: /showRates
so the main logic is when gm exec the command it sends a packet to the world channel which stores the new rates in its memory and also propagate the new rates to all channels which then store them also.
when ever a new channel establishes a connection with the world , world will send its rates through the ChannelOk handler, we want this in cases when a new channel registers/channel restarts after GM executed a command and we want the command to take effect.
the world server initially gets its rates from the config file, and if for example it restarts it will override any new rates GM wrote.