search

HuddleEng / PhantomCSS

Visual/CSS regression testing with PhantomJS
MIT License
4.72k stars 259 forks source link

Double the downloads #118

Closed robcolburn closed 9 years ago

robcolburn commented 9 years ago

PhantomCSS made me download & install Phantom twice.

I've got Phantom 2.0.0 installed locally, and casperjs-1.1.0-beta3 with it's own copy of Phantom 1.8.2.

$ npm i

> phantomjs@1.9.7-14 install /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/phantomjs
> node install.js

PhantomJS detected, but wrong version 2.0.0 @ /usr/local/bin/phantomjs.
Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.7-macosx.zip
Saving to /var/folders/wy/y8gz_nzd6x58_vxn0cp_lky80000gp/T/phantomjs/phantomjs-1.9.7-macosx.zip
Receiving...
  [=======================================-] 99% 0.0s
Received 9186K total.
Extracting zip contents
Copying extracted folder /var/folders/wy/y8gz_nzd6x58_vxn0cp_lky80000gp/T/phantomjs/phantomjs-1.9.7-macosx.zip-extract-1430834765209/phantomjs-1.9.7-macosx -> /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/phantomjs/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/phantomjs/lib/phantom/bin/phantomjs

> phantomjs@1.9.16 install /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/casperjs/node_modules/phantomjs
> node install.js

PhantomJS detected, but wrong version 2.0.0 @ /usr/local/bin/phantomjs.
Downloading https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-1.9.8-macosx.zip
Saving to /var/folders/wy/y8gz_nzd6x58_vxn0cp_lky80000gp/T/phantomjs/phantomjs-1.9.8-macosx.zip
Receiving...
  [=======================================-] 98% 0.0s
Received 9187K total.
Extracting zip contents
Removing /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/casperjs/node_modules/phantomjs/lib/phantom
Copying extracted folder /var/folders/wy/y8gz_nzd6x58_vxn0cp_lky80000gp/T/phantomjs/phantomjs-1.9.8-macosx.zip-extract-1430834790114/phantomjs-1.9.8-macosx -> /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/casperjs/node_modules/phantomjs/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/robertcolburn/Sites/heretic/node_modules/phantomcss/node_modules/casperjs/node_modules/phantomjs/lib/phantom/bin/phantomjs
jamescryer commented 9 years ago

See: https://github.com/Huddle/PhantomCSS/issues/106 Though I'm not sure if it actually helps to have the explicit dependency ref in there, for nodejs consumers.

Once PhantomJS 2.1 is out, and CasperJS has full support I'll look to clean this up. Assuming there are no negative side-effects of the double download?

robcolburn commented 9 years ago

@jamescryer - it spends .01% of my data plan :troll:. Yeah, no big deal as long as the module works.