search

HuddleEng / PhantomFlow

Describe and visualise user flows through tests with PhantomJS
MIT License
682 stars 60 forks source link

Viewport is not reset between flows #15

Closed NiGhTTraX closed 10 years ago

NiGhTTraX commented 10 years ago

Need

As a developer
I want my tests to be independent
So that I have a reliable test suite.

Deliverables

The viewport is reset between flows.

Solution

Reset the viewport at the beginning of a flow. Maybe here.

Prerequisites

NiGhTTraX commented 10 years ago

@jamescryer what do you think of the solution? I can spin up a PR in a jiffy.

jamescryer commented 10 years ago

Good suggestion. I think the viewport should be reset here, at the beginning of each unique path

https://github.com/Huddle/PhantomFlow/blob/ae867a7e8671128e0b92b5520336f1f1ee6a1864/lib/phantomFlow.js#L238

A PR would be great!