Move hideElements to be an option.

HuddleEng / PhantomFlow

Describe and visualise user flows through tests with PhantomJS

MIT License

682 stars 60 forks source link

Move hideElements to be an option. #23

Closed sbrandwoo closed 9 years ago

sbrandwoo commented 9 years ago

PhantomFlow currently hides all img and select elements from the output, though the documentation makes no mention of this behaviour. I have moved it to be a top-level option instead.

It's possible that the old hidden behaviour should be the default, but I don't know why anyone would want that behaviour, so decided against it.

jamescryer commented 9 years ago

It's crudely normalising visuals across systems (OS native UI, system speed). You're right, it should be optional, and probably off by default. I'll try to review this PR sometime this week.