search

HuddleEng / PhantomFlow

Describe and visualise user flows through tests with PhantomJS
MIT License
682 stars 60 forks source link

Suppressing verbose logging on single-threaded tests, when optionDebug === 0 #30

Closed pixelheresy closed 9 years ago

pixelheresy commented 9 years ago

Currently, when there are multiple threads and debug option is set to zero, all tests run with minimal logging [passes/fails/etc.], however, when only one test is run at a time, the logging is by default very verbose, can be distracting.

Proposed solution, in branch is as follows: If it is multi-threaded: functions as previously. If single-threaded, but debug is switched to 0 [or not filled in], then "white line" logs are suppressed, as they are on multi-threaded test runs.

In my setup, users will be almost exclusively running one test flow at a time, so unless we are debugging tests, seeing passes/fails is crucial and not verbose messaging and random line breaks.

If rejected, I would appreciate feedback on what better solution the maintainers/contributors would feel would solve this problem. From my vantage point, having a screen or so worth of feedback [rather than 3+] is appropriate when doing normal automated testing and not debugging new flows.

jamescryer commented 9 years ago

I'm happy with this PR. Default behaviors can be subjective, I assumed, if you are running just one test, you're probably debugging. Opting in to debug logging is fine by me.

pixelheresy commented 9 years ago

Sounds good!

Yeah, since I am having to mock services for each test individually [and we get really weird collisions if certain ones are in parallel], single is good.

All in all, everyone seems really impressed with this tool! Thanks for the merge!

pixelheresy commented 9 years ago

Any chance we can have an incremented version? Want to include this in our development pipeline now, but not without the last changes [and I'd want it just deployable/updatable with NPM rather than a direct pull of the repo].

Let me know!