Closed brikendr closed 3 years ago
LGTM. I don't really know much about any gotchas when removing things from proto messages though.
@eskilgh we have made sure to leave a comment on the protofile about the removed filed so that in the future we dont use the same index for new fields. ATM, the sdk is the only consumer of that api so we should be good.
This version removes the "mac" field of the proto definition which is not required anymore by the windows service