MSGSL docker build issue

[DreamingRaven]

Hey Huelse, thanks for updating to seal v3.4.5, and I realise this is not you however when I attempt to build the dockerfile CMake cannot find MSGSL at this line: https://github.com/Huelse/SEAL-Python/blob/0f88e64cafb3cd8f6a8cd99c5935a68c41007805/SEAL/native/src/CMakeLists.txt#L280 giving this error message:

CMake Warning at CMakeLists.txt:280 (find_package):
  No "FindMSGSL.cmake" found in CMAKE_MODULE_PATH.

CMake Warning (dev) at CMakeLists.txt:280 (find_package):
  FindMSGSL.cmake must either be part of this project itself, in this case
  adjust CMAKE_MODULE_PATH so that it points to the correct location inside
  its source tree.

  Or it must be installed by a package which has already been found via
  find_package().  In this case make sure that package has indeed been found
  and adjust CMAKE_MODULE_PATH to contain the location where that package has
  installed FindMSGSL.cmake.  This must be a location provided by that
  package.  This error in general means that the buildsystem of this project
  is relying on a Find-module without ensuring that it is actually available.

This warning is for project developers.  Use -Wno-dev to suppress it.

and

CMake Error at cmake_install.cmake:64 (file):
  file INSTALL cannot find "/app/SEAL/native/src/cmake/FindMSGSL.cmake".

make: *** [Makefile:118: install] Error 1

I will add in MSGSL to the dockerfile but im not sure what it is, Is it this? https://github.com/Microsoft/GSL Side note nothing is specified in https://github.com/Huelse/SEAL-Python#linux section about MSGSL.

TLDR: Trying to find out what MSGSL is so I can add it in to the Dockerfile so we can verify it works on linux, and more easily reproduce seal-python.

[DreamingRaven]

Tried on linux docker which can be seen here(https://github.com/DreamingRaven/SEAL-Python/blob/3.4.5/Dockerfile) with https://github.com/Microsoft/GSL this doesnt seem to be it, its not building with this either.

[Huelse]

Sorry for that, I haven't tested the docker file before. GSL is a Microsoft numerical lib. in SEAL/native/src/cmake you can find Findmsgsl.cmake, which is lowercase msgsl, just upper it.

[DreamingRaven]

Ah ok will try that shortly. Strange that Microsoft has another GSL project.

[DreamingRaven]

Yep all works fine, cheers, I was blind not to see it in the error message ...