search

Huelse / SEAL-Python

Microsoft SEAL 4.X For Python
MIT License
310 stars 66 forks source link

Feature dockerfile re-introduction for latest code and git-submodules #62

Closed DreamingRaven closed 3 years ago

DreamingRaven commented 3 years ago

Hey Huelse long time no chat.

I have created a short PR to re-introduce a new Dockerfile, with the up-to-date procedure as per your README including syncing sub-modules. I noticed that you did not purge the previous .dockerignore so I modified it to work (I.E so .git is no longer ignored since it is necessary for syncing sub-modules). I have added instructions to the README on docker usage, and I have removed the invisible characters that were sometimes between lines. Also I added git to the list of requirements in the Linux section of the README since that is also needed technically. This time I also made the Dockerfile drop you straight into an interactive python terminal (assuming you provide the -it or more specifically the -i flag to docker as per the README).

What do you think? This can probably help automate testing as well, so github or gitlab as the case may be, can build this Dockerfile and run some simple tests to make sure its working with every commit.

G

Huelse commented 3 years ago

Thank you very much for your contribution, I got a lot of work to do so that I have no time to maintain this project, hoping we can continue to do better in the future!

DreamingRaven commented 3 years ago

Yeah its great work @Huelse I hugely appreciate all that you have done thus far! If I have time I will continue to add little bits here and there and create some PR's as I will be using this for a long time with my DeepCypher/ FHE deep learning project: https://gitlab.com/GeorgeRaven/python-reseal and https://gitlab.com/deepcypher But yeah if we find some time I would defo be up for sorting things out/ updating as needed.