search

Huelse / SEAL-Python

Microsoft SEAL 4.X For Python
MIT License
319 stars 66 forks source link

Add Dockerfile and docker_build.sh script #8

Closed uriariel closed 4 years ago

uriariel commented 4 years ago

I thought that it might be a good idea to add docker integration into the project :)

Huelse commented 4 years ago

Fine, but in fact, there are 2 choices that can build this lib. Both choice need build the SEAL lib at first, and numpy. one is python3 setup.py build_ext -i or python3 setup.py install, the second command suggest using in virtual environment. By the way, this can use in windows with VS2017 or higher. another is make, this choice needs install pybind11 pip3 install -r requirements.txt or make install (pybind11), to ensure the cmake can find it.

Can you improve the script? Thank you!

uriariel commented 4 years ago

Of course I'm sorry, I couldn't attend to your message until now. You want me to remove the redundant build command (python3 setup.py build_ext -i)?

On Fri, Feb 28, 2020 at 6:11 PM Huelse notifications@github.com wrote:

Merged #8 https://github.com/Huelse/SEAL-Python/pull/8 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Huelse/SEAL-Python/pull/8?email_source=notifications&email_token=AD5CJL6IIMWDYZLQDTN3GELRE7Q2PA5CNFSM4K5OJTWKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW654GGI#event-3082535705, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5CJL4FPA6MJOX6KPZVR7LRE7Q2PANCNFSM4K5OJTWA .

-- בברכה אורי אריאל יהלום

Huelse commented 4 years ago

@uriariel I mean, it don't need to compile the pybind11, and only needs run python3 setup.py install

uriariel commented 4 years ago

Ok, will do.

On Mon, Mar 2, 2020, 10:29 Huelse notifications@github.com wrote:

@uriariel https://github.com/uriariel I mean, it don't need to compile the pybind11, and only needs run python3 setup.py install

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Huelse/SEAL-Python/pull/8?email_source=notifications&email_token=AD5CJLZ52NHVQ75O67Y7HALRFNU43A5CNFSM4K5OJTWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOL4CY#issuecomment-593280523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5CJLZQ7DU4EICPKOHCX4DRFNU43ANCNFSM4K5OJTWA .