search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
76 stars 29 forks source link

feat: Enable or disable env flags replace to cargo feature #102

Closed ikrivosheev closed 1 year ago

ikrivosheev commented 1 year ago

I think is more useful to use cargo feature instead of env variables for enable or disable compile options.

Hugal31 commented 1 year ago

Looks better! You'll have to re-add the default features in the Github actions everywhere --no-default-features is specified though. You can also remove the YARA_ENABLE_HASH in test.yml.

Also, I think the linter is failing because the pipeline specifies --all-features.

ikrivosheev commented 1 year ago

Looks better! You'll have to re-add the default features in the Github actions everywhere --no-default-features is specified though. You can also remove the YARA_ENABLE_HASH in test.yml.

Also, I think the linter is failing because the pipeline specifies --all-features.

@Hugal31 thank you for review! Done.