search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
70 stars 30 forks source link

Github action cannot build on Windows with OpenSSL #113

Open Hugal31 opened 1 year ago

Hugal31 commented 1 year ago

We get this error : D:\a\yara-rust\yara-rust\target\debug\build\yara-sys-a7d675839598f617\out\yara\libyara\crypto.h(38): fatal error C1083: Cannot open include file: 'openssl/crypto.h': No such file or directory

Both on https://github.com/Hugal31/yara-rust/actions/runs/4627586826/jobs/8185675294?pr=108 and https://github.com/Hugal31/yara-rust/actions/runs/4627507725/jobs/8185510282. But it worked fine on Yara 4.3.0 PR, and nothing relevant changed since.

Hugal31 commented 1 year ago

OpenSSL disabled on Windows for now in #108.

vthib commented 1 year ago

Not sure why it worked before and suddently didn't work, but I think adding YARA_OPENSSL_DIR instead of OPENSSL_DIR should solve the issue. I had the same issue on updating to yara-rust 0.19 and adding YARA_OPENSSL_DIR fixed it: https://github.com/vthib/boreal/pull/31/files