search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
70 stars 30 forks source link

deps: update to bindgen 0.68 #129

Closed poliorcetics closed 10 months ago

poliorcetics commented 10 months ago

I think the bindings should be updated but I'm unsure how to do it properly and I don't have a way to check the results for all supported targets.

Hugal31 commented 10 months ago

I'm all for upgrading and stuff, but do you have a particular reason to update bindgen? The changelog doesn't seem to mention anything relevant for this crate.

The pipeline is here to check if it still works with all the supported targets. Can you just download the resulting artifacts (the generated bindings) and commit them if they changed?

poliorcetics commented 10 months ago

I'm all for upgrading and stuff, but do you have a particular reason to update bindgen? The changelog doesn't seem to mention anything relevant for this crate.

Mostly to avoid duplicated dependencies in Cargo.lock, since it means building basically the same thing several times for no real reason. Also in this particular case, I wanted to check if CStr fix and clippy lint were applicable but it seems they aren't

The pipeline is here to check if it still works with all the supported targets. Can you just download the resulting artifacts (the generated bindings) and commit them if they changed?

Thanks! There are a few more Windows constants and nothing else