search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
77 stars 28 forks source link

show cc compilation wanings #27

Closed Orycterope closed 3 years ago

Orycterope commented 3 years ago

I've just lost a week debugging an optimized undefined behaviour in libyara which was clearly hinted by clang, but the warnings were suppressed in the build.rs.

This PR re-enables all warnings, except for a few harmless warning families to avoid spam during compilation.

I've tried to review all the warnings we get on x86, x64, linux, windows, with both clang and cl, and disable all warning families that are clearly harmless for us. The only one that concerns me is -Wsign-compare, but it also is the more frequent by far, so I've also disabled it.

Hugal31 commented 3 years ago

LGTM

I hope your PR on libyara will be merged soon! Do you think we should include a mention of this UB at least in the README? Or maybe add a runtime warning or a quickfix before your PR is merged?

Orycterope commented 3 years ago

Thank you. The PR to libyara is already merged, but not yet released.

Regarding the mention to this UB, this PR is precisely here to display the warning when compiling for windows, so we should be fine.