search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
74 stars 29 forks source link

Add more compile options for libyara #32

Closed ikrivosheev closed 3 years ago

ikrivosheev commented 3 years ago

Add more options for yara-sys:vendored and describe it in docs

ikrivosheev commented 3 years ago

@Hugal31 this PR is ready, can you review?

Hugal31 commented 3 years ago

You removed the NDEBUG flag. Is this wanted?

Also, I would like to highlight there is a breaking change: you now have to manually enable the DEX, DOTNET and MACHO features. It is ok for the though.

ikrivosheev commented 3 years ago

You removed the NDEBUG flag. Is this wanted?

Also, I would like to highlight there is a breaking change: you now have to manually enable the DEX, DOTNET and MACHO features. It is ok for the though.

Thank you for review, I fix:

  1. NDEBUG - enable by default
  2. DEX, DOTNET, MACHO - enable by default
  3. Fix README.md