Closed ikrivosheev closed 3 years ago
Thanks for your PR, it looks great! I left a few comments for things I'd like to change. Could you also add a few unit tests please?
Thank you for review!
I have a question: Scanner callback API make similar Rule callback API or set callback into Scanner, like this:
let rules = Rules...;
let scanner = rules.scanner();
scanner.set_callback(...);
scanner.set_timeout(...);
?
I have a question: Scanner callback API make similar Rule callback API or set callback into Scanner, like this:
let rules = Rules...; let scanner = rules.scanner(); scanner.set_callback(...); scanner.set_timeout(...);
?
I'm not sure. I think I prefer to keep it as the Rule API, it might be more convenient to use closures.
@Hugal31, I add Scanner callback API
@Hugal31 rebase master.
Can you make release? I need this changes in project
v0.8.0 released!
Hello @Hugal31 , sorry for my english, I will try to describe what I want to do.
If this PR is Ok, I can write Callback API for Scanner