search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
74 stars 29 forks source link

Add MacOS build #41

Closed ikrivosheev closed 3 years ago

ikrivosheev commented 3 years ago

Fix: https://github.com/Hugal31/yara-rust/issues/40

I only added build without tests, since I am having problems with test on MacOS: https://github.com/ikrivosheev/yara-rust/runs/3270599324?check_suite_focus=true#step:4:204

ikrivosheev commented 3 years ago

@Hugal31 can you review this PR? Thank you)

ikrivosheev commented 3 years ago

@hexgnu ping?)

hexgnu commented 3 years ago

I don't know if I'm the right person to review this since I don't own a mac.

From the glance of it it looks good to me though :).

ikrivosheev commented 3 years ago

@hexgnu, @hexgnu, it might be worth adding flags for static linking with: OpenSSL, libmagic, jansson?

hexgnu commented 3 years ago

Yea I mean that makes sense

Hugal31 commented 3 years ago

LGTM, I'm merging. Thank you!

Sorry for the delay.