Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
73 stars 29 forks source link

feat: upgrade yara to 4.2.1 #72

Closed ikrivosheev closed 2 years ago

ikrivosheev commented 2 years ago

New version for yara is released: https://github.com/VirusTotal/yara/releases/tag/v4.2.0.

vthib commented 2 years ago

Any news on this update? I've tested it locally on a linux setup (with vendored and vendored,bundled-4_2_0) and it works fine, i'm not sure what the check failures are

ikrivosheev commented 2 years ago

Any news on this update? I've tested it locally on a linux setup (with vendored and vendored,bundled-4_2_0) and it works fine, i'm not sure what the check failures are

I so sorry for the delay, I have some problems with my laptop. I will finish in 2-3 days

ikrivosheev commented 2 years ago

@vthib I think I found bug in yara c library. Bug is infinity loop when scan process by pid.

I will report today.

ikrivosheev commented 2 years ago

@vthib @Hugal31 done for Linux and MacOs. I upgrade yara to 4.2.1. Can someone generate bindgen for Windows?

Hugal31 commented 2 years ago

Isn't there a way to run bindgen on Windows via Github actions and retrieved the generated files? I think this has been done when the project used Travis.

ikrivosheev commented 2 years ago

Isn't there a way to run bindgen on Windows via Github actions and retrieved the generated files? I think this has been done when the project used Travis.

Good idea. I think about this, I will try to make it.

vthib commented 2 years ago

I have generated the bindings for the x86_64-pc-windows-msvc target, here it is: https://pastebin.com/fiFgjpxA

ikrivosheev commented 2 years ago

@vthib thank you!

ikrivosheev commented 2 years ago

@Hugal31 what do you think if I make this:

Isn't there a way to run bindgen on Windows via Github actions and retrieved the generated files? I think this has been done when the project used Travis.

In other PR?

ikrivosheev commented 2 years ago

@vthib thank you! yara-sys now build for Windows