search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
73 stars 29 forks source link

fix: Drop struct #75

Closed ikrivosheev closed 2 years ago

ikrivosheev commented 2 years ago

Problem was describe here: https://github.com/Hugal31/yara-rust/issues/74. After fix drop, I got: Segmentation fault (core dumped), because context.matches was NULL and I fix it too.

ikrivosheev commented 2 years ago

@Hugal31 can you review this MR? I need it.

Hugal31 commented 2 years ago

I changed the as_yara function so it is impossible to make the mistake of dropping the wrapper.

ikrivosheev commented 2 years ago

I changed the as_yara function so it is impossible to make the mistake of dropping the wrapper.

Thank you! Awesome!

ikrivosheev commented 2 years ago

@Hugal31 can you make a release with this fix? This blocks me.