search

Hugal31 / yara-rust

Rust bindings for VirusTotal/Yara
Apache License 2.0
73 stars 29 forks source link

feat: pre-generated bindings for target #80

Closed ikrivosheev closed 2 years ago

ikrivosheev commented 2 years ago

Close: https://github.com/Hugal31/yara-rust/issues/52

ikrivosheev commented 2 years ago

@Hugal31 done! Can you review?

ikrivosheev commented 2 years ago

@Hugal31 I see we have only 3 different bindings...

sha256sum *
fc180d619b96d63c608fd465433709e3b4c3c47e88b2c683d8dfd1ba9c002e56  yara-4.2.1-i686-pc-windows-gnu.rs
fc180d619b96d63c608fd465433709e3b4c3c47e88b2c683d8dfd1ba9c002e56  yara-4.2.1-i686-pc-windows-msvc.rs
fc180d619b96d63c608fd465433709e3b4c3c47e88b2c683d8dfd1ba9c002e56  yara-4.2.1-x86_64-pc-windows-gnu.rs
fc180d619b96d63c608fd465433709e3b4c3c47e88b2c683d8dfd1ba9c002e56  yara-4.2.1-x86_64-pc-windows-msvc.rs
608d6af6ea210c8abacdce8a248b66a2a5311b343cca9c020f410193e3484c20  yara-4.2.1-x86_64-apple-darwin.rs
46ff01af68b1ce1fcd45e94b2a8763cb30a5c2ce6c0161c2fef1ede1bc429212  yara-4.2.1-i686-unknown-linux-gnu.rs
46ff01af68b1ce1fcd45e94b2a8763cb30a5c2ce6c0161c2fef1ede1bc429212  yara-4.2.1-aarch64-unknown-linux-gnu.rs
46ff01af68b1ce1fcd45e94b2a8763cb30a5c2ce6c0161c2fef1ede1bc429212  yara-4.2.1-x86_64-unknown-linux-gnu.rs

Update 1: GitHub Actions cannot run on not x86 platform... Here is issue: https://github.com/actions/runner/issues/1181

Update 2: @Hugal31 what do you think about dropping x32 platform from pre-genereted bindings? And we remove UB from code.

Hugal31 commented 2 years ago

Just to be sure, the bindings are the same in i686-pc and x86_64-pc because in fact the runner ran on a x86_64 environment? If so, did aarch64 worked?

To answer your question, I don't see any other option (unless someone is willing to generate the bindings themself).

Anyway, thank you so much for your work!

ikrivosheev commented 2 years ago

Just to be sure, the bindings are the same in i686-pc and x86_64-pc because in fact the runner ran on a x86_64 environment?

Yes.

If so, did aarch64 worked?

No, because GitHub actions run on x86_64

ikrivosheev commented 2 years ago

@Hugal31 after some tries to build aarch64 I get: https://github.com/Hugal31/yara-rust/runs/6987670647?check_suite_focus=true#step:4:665

Leave only x64_86 for linux, windows and mac?