search

Huggenguggen / pe

0 stars 0 forks source link

Edit command sequence diagram unnecessary #13

Open Huggenguggen opened 1 year ago

Huggenguggen commented 1 year ago

While it is appreciated that effort has been put to make the sequence diagrams, Edit Command section has a very tall sequence diagram that not only is broken into 2 pages, but is also unnecessary as the logic is the same for each attribute.

image.png

nus-pe-script commented 1 year ago

Team's Response

I am not sure if this affects the reading, but felt it was necessary for the documentation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Going by the textbook,

image.png

I think this would count under the bug where visuals are unnecessarily repetitive.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]