Huggenguggen / pe

0 stars 0 forks source link

Delete command not working as expected #3

Open Huggenguggen opened 1 year ago

Huggenguggen commented 1 year ago

image.png

Recreate: delete 1 2 3

Expected: it will delete the third index Actual: it throws an error

The UG specifies if a parameter is expected only once in the command but you specified it multiple times, only the last occurrence of the parameter will be taken.

Fix: Either fix the behavior to be consistent with UG, or change the UG.

soc-se-bot commented 1 year ago

Team's Response

Accepted, but this should be a DocumentationBug. For our documentation, we were referring to the "parameters" of a role when we mentioned that "when a parameter is expected once, it will take the last instance of the parameter". We were not referring to the general "parameters" of a command.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: While you could differentiate between the "parameters" of a role vs the "parameters" of a command, I would find that pedantic and not intuitive as a user. As such, I still section this under a Functionality Bug. Going by the textbook,

image.png

I also think this qualifies as a Functionality Bug. As a developer myself, it should be possible to implement and accommodate the multiple parameter issue in commands like delete and edit.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** There was no justification for why the severity was lowered but going by the textbook, ![image.png](https://raw.githubusercontent.com/Huggenguggen/pe/main/files/60db8aae-aa51-4da8-b226-22cf531e48b9.png) This can cause inconvenience to some users who misunderstood your UG and assumes the behavior that I outlined. However, those users can still continue to use your product once they experiment and figure out the intended interaction, as such, I label it as medium.