search

HughP / simal

Automatically exported from code.google.com/p/simal
0 stars 0 forks source link

Add classes to HTML elements to improve stylability #391

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The attached is all the changes I've made so far in adding CSS classes to HTML 
elements. It's not really tidy or complete, but I'd like to get some of these 
checked in to avoid getting ambushed by more changes in the repository.

Some of these classes are set by code in Java, whereas they could and should be 
set statically in the HTML. Oops.

Original issue reported on code.google.com by Stevage on 23 Feb 2011 at 2:26

Attachments:

GoogleCodeExporter commented 9 years ago 
There are a number of problems with this patch. The first is, as you observe, 
quite a few HTML clases are set in the java rather than the HTML. This is bad 
practice and difficult to maintain. There are one or two placed where the class 
is changed depending on the number of rows - naturally this is necessary in the 
java code.

There are also some very large changes to files that appear to be white space 
only, but the number of changes makes it very difficult to review those files 
before committing.

Please resubmit with these two issues addressed and we'll apply immediately.

In general it is best to submit small cange sets as it makes reviewing much 
easier. Each change should address a single issue (i.e. style the x section of 
the edit page)

Original comment by ross.gardler on 23 Feb 2011 at 9:01

GoogleCodeExporter commented 9 years ago 
Ok, I've had a closer look at Eclipes's SVN integration - looks like I vastly 
underestimated it.

The attached diff just covers classes in html files. Looks like the noise in 
PersonBrowserPage.html was due to line endings.

Original comment by Stevage on 24 Feb 2011 at 3:36

Attachments:

GoogleCodeExporter commented 9 years ago 
This one converts some div's to h3's. Sorry for the whitespace stuff in 
projectlistpanel. I tried. I really did. But the file is half-Windows, 
half-Unix. And Subclipse just refuses to ignore whitespace changes when 
generating diffs.

Original comment by Stevage on 24 Feb 2011 at 5:49

Attachments:

GoogleCodeExporter commented 9 years ago 
This one adds classes to elements in EditProjectPanel.html (rather than using 
AttributeAppender).

Original comment by Stevage on 7 Mar 2011 at 6:00

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by ross.gardler on 14 Mar 2011 at 2:12