HughP / simal

Automatically exported from code.google.com/p/simal
0 stars 0 forks source link

Improve usability of doapcreator #392

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I roughly split the javascript into several files, and improved the usability 
of the whole thing (no alert(), for instance). No change to actual fields or 
meaning.

Original issue reported on code.google.com by Stevage on 23 Feb 2011 at 7:38

Attachments:

GoogleCodeExporter commented 9 years ago
Improved quite a bit more. I added a "don't validate" checkbox, useful for 
testing. There's also a (by default hidden) text box that allows you to inject 
javascript. Useful for me, perhaps not for others.

Original comment by Stevage on 8 Mar 2011 at 12:59

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the zip Steve, but I'm afraid I can't process this as-is.

It's a zip containing all the files of the doapcreator plus all the svn files.

We really need a diff file that's as atomic as possible, so one fix per patch. 
It's much easier to apply four patches that all have one fix or improvement, 
than having to figure out what's new in all the files submitted. I have the 
impression that there are useful improvements in the zip but please resubmit 
them as atomic patches.

Also, I'm afraid we can't put test code in the trunk, because that's what the 
releases will be built from. Unless you build in a very secure way of turning 
on/off the testing part (which is probably not worth the effort) we can't 
accept it in the codebase, I'm afraid.

I'd like to stress that we really appreciate your submissions, and I hope you 
can repackage your improvements as atomic diff files so I can evaluate them 
properly.

Original comment by sander.v...@oucs.ox.ac.uk on 11 Mar 2011 at 2:03