HughP / simal

Automatically exported from code.google.com/p/simal
0 stars 0 forks source link

CLI: getProjects with no filter returns nothing #405

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
So I spent ages thinking something was wrong with repository initialisation. 
This patch is a bit friendlier.

Original issue reported on code.google.com by Stevage on 9 Mar 2011 at 1:31

Attachments:

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2225.

Original comment by sander.v...@oucs.ox.ac.uk on 11 Mar 2011 at 12:43

GoogleCodeExporter commented 9 years ago
Thanks for the patch Steve, now applied. Although the policy is to apply 
patches with unit tests only, especially when the 'flow of execution' changes 
like in this case, I do realise there are no unit tests for this class at all 
so I applied the patch as-is. A description of what the patch functionally does 
in the issue would have been helpful though. In any case: 

The CLI command 'getProjects' is now also executed if the name filter is not 
used. Plus few logging typos are fixed.

Original comment by sander.v...@oucs.ox.ac.uk on 11 Mar 2011 at 12:47