search

HughParsonage / grattan

Common quantitative tasks for Australian policy analysts
25 stars 8 forks source link

Fix failing test #215

Closed hadley closed 3 years ago

hadley commented 3 years ago

In the next version of dtplyr, select automatically converts to a lazydt so this test no longer works. I don't really understand the point of this test since unselect is just a wrapper around hutils::drop_cols, so I just verified that the columns are dropped as expected.

HughParsonage commented 3 years ago

Thank you @hadley . This test is very old -- I will probably just remove unselect_ eventually. I've accepted the PR -- when do you need the patch published to CRAN? (The package has recently been updated.)

hadley commented 3 years ago

In the next week or two would be great.