HugoBlox / hugo-blox-builder

🚨 GROW YOUR AUDIENCE WITH HUGOBLOX! 🚀 HugoBlox is an easy, fast no-code website builder for researchers, entrepreneurs, data scientists, and developers. Build stunning sites in minutes. 适合研究人员、企业家、数据科学家和开发者的简单快速无代码网站构建器。用拖放功能、可定制模板和内置SEO工具快速创建精美网站!
https://hugoblox.com/templates/
MIT License
8.2k stars 2.9k forks source link

The fix committed in cae10885 does not fix #1726 #1729

Closed kortschak closed 4 years ago

kortschak commented 4 years ago

The commit cae10885865961a2a3f5b5a406fb62368184ee00 which removes logic added in kortschak/hugo-academic@dc34cac0f066f26fa755b1a8ba17e96bb6330963 for handling the license icons does not correctly fix #1726.

For example, with copyright_license = {enable = true, allow_derivatives = false, share_alike = true, allow_commercial = true, notice = ""}, cae10885865961a2a3f5b5a406fb62368184ee00 renders the following

Screenshot from 2020-06-03 08-41-02

while the correct image should be

Screenshot from 2020-06-03 08-41-25

according to the license page.

This is the image rendered by kortschak/hugo-academic@dc34cac0f066f26fa755b1a8ba17e96bb6330963 Screenshot from 2020-06-03 08-44-43

This follows from the fact that the logic in the html portion of the template rendering the icons matches the logic for determining the license URL in kortschak/hugo-academic@dc34cac0f066f26fa755b1a8ba17e96bb6330963, but not in cae10885865961a2a3f5b5a406fb62368184ee00.

gcushen commented 4 years ago

See ff252a6