RelPermalink instead of Permalink for background image in block v2

[ladychb]

Preliminary Checks

• [X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/wowchemy/wowchemy-hugo-themes/issues?q=is%3Aissue
• [X] This issue is not a question, feature request, or anything other than a bug report directly related to Wowchemy. Please post those things on Discord: https://discord.gg/z8wNYzb

Description

In parse_block_v2, currently in line 50: https://github.com/wowchemy/wowchemy-hugo-themes/blob/15ee0927a7f315b7d05d5eedc26911527cf01fe3/modules/wowchemy/layouts/partials/functions/parse_block_v2.html#L50

the code line says: {{ $style_bg = printf "%sbackground-image: url('%s');" $style_bg $bg_img.Permalink }}

It should be RelPermalink instead of Permalink.

For GitHub organizations with more than repository with different custom domains, Permalink does not resolve correctly as it links to the GitHub organization url but not the custom domain relink.

Reproduction Link

https://github.com/chbeu/chbnet.github.io

Steps to Reproduce

already corrected in this repository:

use a background image in block_v2.

e.g., in this example:

• block: markdown design: background: image: filename: top/8755.jpeg

Expected Result

the url of the first bg-image is resolved as: url(/media/top/8755_hub69d488ded179fe2d79c316e7804705e_9279888_1920x1920_fit_q95_h2_lanczos.webp)

Actual Result

without change from Permalink to RelPermalink, the bg-image is resolved as: url(https://chbeu.github.io/media/top/8755_hub69d488ded179fe2d79c316e7804705e_9279888_1920x1920_fit_q95_h2_lanczos.webp)

What Hugo Module versions does your site use?

module github.com/chbeu/chbnet.github.io

go 1.20

require ( github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-netlify v1.0.1-0.20230807174326-15ee0927a7f3 github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-netlify-cms v1.0.1-0.20230807174326-15ee0927a7f3 github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-reveal v0.0.0-20221029143146-ff4b7b1193fa github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy/v5 v5.8.0 )

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome, Safari

Which Wowchemy template are you using?

https://github.com/wowchemy/hugo-minimal-theme

What version of Hugo are you using?

hugo extended v0.117.0

[gcushen]

Have you seen the comments in the code - it's purposely using Permalink as that is what was advised by the creator of Hugo:

https://github.com/wowchemy/wowchemy-hugo-themes/blob/15ee0927a7f315b7d05d5eedc26911527cf01fe3/modules/wowchemy/layouts/partials/functions/parse_block_v2.html#L43

If you think there's an issue with Permalink and GitHub, the best place to raise the issue is in the Hugo repo: https://github.com/gohugoio/hugo/issues/new/choose