Update to 5.9.3 with slides failes due to functions/get_icon error

WebDucer commented 1 year ago

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/wowchemy/wowchemy-hugo-themes/issues?q=is%3Aissue
[X] This issue is not a question, feature request, or anything other than a bug report directly related to Wowchemy. Please post those things on Discord: https://discord.gg/z8wNYzb

Description

After update to version 5.9.3, the compilation of the site failed (error output below).

2 other pages updated successfully (contain no slides).

Reproduction Link

https://github.com/Richter-Consulting/ionos-schulungen

Steps to Reproduce

Update the template from version 5.8.1 to 5.9.3

Expected Result

The site is compiled

Actual Result

PS C:\src\homepage> hugo server --logLevel debug
Watching for changes in C:\{Users,src}
Watching for config changes in C:\src\WebDucer\ionos-schulungen\config\_default, C:\Users\One\AppData\Local\hugo_cache\modules\filecache\modules\pkg\mod\github.com\wowchemy\wowchemy-hugo-themes\modules\wowchemy-bootstrap\v5@v5.9.3\config.yaml, C:\src\homepage\go.mod
Start building sites …
hugo v0.120.3-a4892a07b41b7b3f1f143140ee4ec0a9a5cf3970+extended windows/amd64 BuildDate=2023-11-01T17:57:00Z VendorInfo=gohugoio

INFO  copy static: syncing static files to \
INFO  build: running step "process" duration "6.309ms"
INFO  build: running step "assemble" duration "145.2039ms"
DEBUG Set expanded permalink path for page event\git-2021-2\index.md to "/termine/git-kurs-2021-ii/"
DEBUG Set expanded permalink path for page event\git-2022-1\index.md to "/termine/git-kurs-2022-i/"
DEBUG Set expanded permalink path for page event\git-2023-1\index.md to "/termine/git-kurs-2023-i/"
DEBUG Set expanded permalink path for page event\git-2023-2\index.md to "/termine/git-kurs-2023-ii/"
DEBUG Set expanded permalink path for page event\git-2024-1\index.md to "/termine/git-kurs-2024-i/"
DEBUG Set expanded permalink path for page event\macos-2022-1\index.md to "/termine/macos-kurs-2022-i/"
DEBUG Set expanded permalink path for page event\macos-2022-2\index.md to "/termine/macos-kurs-2022-ii/"
DEBUG Set expanded permalink path for page event\macos-2023-1\index.md to "/termine/macos-kurs-2023-i/"
DEBUG Set expanded permalink path for page event\macos-2023-2\index.md to "/termine/macos-kurs-2023-i/"
DEBUG Set expanded permalink path for page event\macos-2024-1\index.md to "/termine/macos-kurs-2024-i/"
DEBUG Set expanded permalink path for term in [tags git] to "/tag/git/"
DEBUG Set expanded permalink path for term in [tags kurs] to "/tag/kurs/"
DEBUG Set expanded permalink path for term in [tags macos] to "/tag/macos/"
DEBUG Set expanded permalink path for term in [tags mvhs] to "/tag/mvhs/"
DEBUG Set expanded permalink path for term in [tags online] to "/tag/online/"
DEBUG Set expanded permalink path for term in [tags vcs] to "/tag/vcs/"
DEBUG Set expanded permalink path for term in [tags versionsverwaltung] to "/tag/versionsverwaltung/"
INFO  Data for key 'buttons' in path 'page_sharer.toml' is overridden by higher precedence data already in the data tree
INFO  deprecated: .Site.GoogleAnalytics was deprecated in Hugo v0.120.0 and will be removed in a future release. Use .Site.Config.Services.GoogleAnalytics.ID instead.
INFO  build: running step "render" duration "418.1205ms"
INFO  build: running step "postProcess" duration "0s"
Built in 569 ms
Error: error building site: render: failed to render pages: render of "page" failed: "C:\Users\One\AppData\Local\hugo_cache\modules\filecache\modules\pkg\mod\github.com\wowchemy\wowchemy-hugo-themes\modules\wowchemy-plugin-reveal@v1.0.0\layouts\slides\baseof.html:19:45": execute of template failed: template: slides/single.html:19:45: executing "slides/single.html" at <partial "functions/get_icon" 32>: error calling partial: partial "functions/get_icon" not found

What Hugo Module versions does your site use?

module github.com/wowchemy/starter-hugo-academic

go 1.15

require (
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-bootstrap/v5 v5.9.3
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-core v0.2.1-0.20231105000840-20f6ecb81f55 // indirect
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-netlify v1.0.0 // indirect
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-reveal v1.0.0 // indirect
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-seo v0.1.1-0.20231105000840-20f6ecb81f55 // indirect
)

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

Which Wowchemy template are you using?

Starter Hugo Academic

What version of Hugo are you using?

ugo v0.120.3-a4892a07b41b7b3f1f143140ee4ec0a9a5cf3970+extended windows/amd64 BuildDate=2023-11-01T17:57:00Z VendorInfo=gohugoio

WebDucer commented 1 year ago

It looks like, not fixed version of the reveal module is loaded (wowchemy-plugin-reveal@v1.0.0\layouts\slides\baseof.html):

<!DOCTYPE html>
<html lang="{{ site.LanguageCode | default "en-us" }}">
<head>

  {{/* Asset versions */}}
  {{ $cdn_url_reveal := "https://cdn.jsdelivr.net/npm/reveal.js@4.3.1" }}
  {{ $mermaid_version := "9.1.3" }}
  {{ $mermaid_sri := "sha256-TIYL00Rhw/8WaoUhYTLX9SKIEFdXxg+yMWSLVUbhiLg=" }}

  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <meta http-equiv="X-UA-Compatible" content="IE=edge">
  <meta name="generator" content="Wowchemy {{with site.Data.wowchemy.version}}{{.}}{{end}} for Hugo">

  {{ with site.Home.OutputFormats.Get "WebAppManifest" }}
    <link rel="manifest" href="{{ .RelPermalink }}">
  {{ end }}

  <link rel="icon" type="image/png" href="{{(partial "functions/get_icon" 32).RelPermalink}}">
  <link rel="apple-touch-icon" type="image/png" href="{{(partial "functions/get_icon" 192).RelPermalink}}">
...

WebDucer commented 1 year ago

Found the issue.

Instead of using the hugo mod get -u to update the modules in go.mod, I copied the "versions" from the current templates in this repo.

Then the build worked as expected

module github.com/wowchemy/starter-hugo-academic

go 1.15

require (
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-bootstrap/v5 v5.9.3
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-netlify v1.0.1-0.20231102163809-66b38685ac69
    github.com/wowchemy/wowchemy-hugo-themes/modules/wowchemy-plugin-reveal v0.0.0-20231102163809-66b38685ac69
)

gcushen commented 1 year ago

If you have further questions, please ask in the Discord channel.

HugoBlox / hugo-blox-builder