HugoBlox / hugo-blox-builder

🚨 GROW YOUR AUDIENCE WITH HUGOBLOX! 🚀 HugoBlox is an easy, fast no-code website builder for researchers, entrepreneurs, data scientists, and developers. Build stunning sites in minutes. 适合研究人员、企业家、数据科学家和开发者的简单快速无代码网站构建器。用拖放功能、可定制模板和内置SEO工具快速创建精美网站!
https://hugoblox.com/templates/
MIT License
8.15k stars 2.9k forks source link

Dark mode breaks highlighting lines in code blocks #3084

Closed thomwiggers closed 3 weeks ago

thomwiggers commented 6 months ago

Description

I use the hl_lines feature of Hugo to highlight some lines in a code block:

Code:

```Makefile {linenos=table, hl_lines="1 3-5"}
all: mag.pdf fog.pdf prohibited.pdf unicorn.pdf detective.pdf

%.pdf: generator.tex
    lualatex -jobname='$(subst .pdf,,$@)' \
        '\def\theemoji{$(subst .pdf,,$@)}\input{generator.tex}'
```

Output: image

But in dark mode this becomes unreadable:

image

Reproduction Link

https://github.com/thomwiggers/thomwiggers.nl/blob/main/content/post/emoji-in-latex/index.md

Rendered at https://thomwiggers.nl/post/emoji-in-latex/

What Hugo Module versions does your site use?

require (
    github.com/HugoBlox/hugo-blox-builder/modules/blox-bootstrap/v5 v5.9.7 // indirect
    github.com/HugoBlox/hugo-blox-builder/modules/blox-core v0.3.1 // indirect
    github.com/HugoBlox/hugo-blox-builder/modules/blox-plugin-netlify v1.1.1 // indirect
    github.com/HugoBlox/hugo-blox-builder/modules/blox-plugin-reveal v1.1.2 // indirect
    github.com/HugoBlox/hugo-blox-builder/modules/blox-seo v0.2.2 // indirect
)

What operating system(s) are you seeing the problem on?

macOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari

Which Hugo Blox template are you using?

Academic CV

What version of Hugo are you using?

v0.124.1

gcushen commented 5 months ago

@thomwiggers It may have been due to a Hugo bug when the style was generated with Hugo's 'chromastyles' command? https://github.com/gohugoio/hugo/issues/12393

github-actions[bot] commented 4 months ago

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

thomwiggers commented 4 months ago

we should probably check if the highlight styles need to be recreated, e.g.,

https://github.com/HugoBlox/hugo-blox-builder/blob/main/modules/blox-bootstrap/assets/css/libs/chroma/github-dark.css

github-actions[bot] commented 3 months ago

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

thomwiggers commented 3 months ago

Bump

github-actions[bot] commented 2 months ago

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

thomwiggers commented 2 months ago

The affected files have not yet been touched.

github-actions[bot] commented 1 month ago

This issue is stale because it has not had any recent activity. The resources of the project maintainers are limited, and so we are asking for your help.

If this is a bug and you can still reproduce this error on the main branch, consider contributing a Pull Request with a fix.

If this is a feature request, and you feel that it is still relevant and valuable, consider contributing a Pull Request for review.

This issue will automatically close soon if no further activity occurs. Thank you for your contributions.