search

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).
https://hugofara.github.io/lwt/
The Unlicense
168 stars 19 forks source link

"Height of right top frame" not working #116

Open HenryWales opened 1 year ago

HenryWales commented 1 year ago

Changing the "width of left frames" option in the "Read Text Screen" section correctly changes width, and it is also possible to resize the frame manually when editing a text.

Changing the "height of right top frame" option does nothing. It stays at 50 percent no matter what.

Putting the values in do_text.php to my preferred value works as a workaround but that's a poor solution.

Firefox 112, LWT 2.8.1

HugoFara commented 1 year ago

Hi! I'm aware of this UI issue, I changed the frameset system drastically and brought back the horizontal scaling but not the vertical one.

As any feature can bring it's lot of bugs, can you tell me if it's a necessary feature for you?

HenryWales commented 1 year ago

As any feature can bring it's lot of bugs, can you tell me if it's a necessary feature for you?

A setting exposed in a menu not working makes for a disappointing experience, but I can understand you can't do everything. I think manual live resizing is not necessary, this is a setting that will be touched only occasionally.

It's necessary for me, although I can circumvent the bug with a manual edit of the height values to my preferred values in do_text.php. So there is no urgency.

I need to change the frame height because I'm displaying multiple similar terms and I don't want to scroll to change status or save a definition. I don't use much the integrated dictionary.

ProgramComputer commented 8 months ago

@HenryWales #154 puts handles to change the frame size for the test page. Would a similar setup be preferable in text page?