search

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).
https://hugofara.github.io/lwt/
The Unlicense
168 stars 19 forks source link

Most audio buttons may not work anymore #138

Closed HugoFara closed 5 months ago

HugoFara commented 1 year ago

No JavaScript error was thrown, needs a bit of investigation.

By the way, some of the audio features may not be necessary.

HugoFara commented 8 months ago

After investigation, the issue is not so bad. Only the "go faster" and "go slower" feature was broken. Two JavaScript functions, click_slower and click_faster were redefined in src/js/audio_controller.js, leading to the broken feature.

This will be patched by changing the names of the functions. Renaming yet patch only as are they are not in the documented interface anyway.

HugoFara commented 8 months ago

The replay button is still not working, as the "file end event" ($.jPlayer.event.ended) is no longer triggered. It may be related to the fact that jPlayer is not compatible with jQuery 3.

A modern rewrite using the HTML audio element seems necessary.

HugoFara commented 5 months ago

This was fixed with the help of @ProgramComputer through #191, and release in 2.10.0, happy listening!