search

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).
https://hugofara.github.io/lwt/
The Unlicense
169 stars 19 forks source link

[Feature] Highlight to speech #147

Closed ProgramComputer closed 10 months ago

ProgramComputer commented 1 year ago

Added an option in settings to pronounce word on mouseover.

HugoFara commented 11 months ago

Text-to-speech

I'm having giving a try to your work, I think this feature can be quite cool for some users, which is nice. However, it can become a bit violent when it keeps uttering words so I'm thinking of a third way.

Basically, we would keep your work, but adding another option: "click to speech". When a user clicks a word dispatches speech. The options would look like that:

New speech dispatcher

What do you think of this?

Changes to INSTALL.sh

This is a different issue that should not come in this pull request, so I won't accept them here. I'm not sure why you want these changes either, but I'm open to discussion!

ProgramComputer commented 11 months ago

Text-to-speech

I'm having giving a try to your work, I think this feature can be quite cool for some users, which is nice. However, it can become a bit violent when it keeps uttering words so I'm thinking of a third way.

Basically, we would keep your work, but adding another option: "click to speech". When a user clicks a word dispatches speech. The options would look like that:

New speech dispatcher

What do you think of this?

Changes to INSTALL.sh

This is a different issue that should not come in this pull request, so I won't accept them here. I'm not sure why you want these changes either, but I'm open to discussion!

I've changed back to localhost. Your UI modification as a dropdown is a nice addition. LWT does modify server variables, check for "set globals" such as "max_heap_table_size" and "tmp_table_size". These are not being modified at runtime and only after session restart do these changes appear. Not a concern if SQL interactions are handled safely. This line sudo mysql -e "GRANT SYSTEM_VARIABLES_ADMIN ON *.* TO $user@$host" prevents the need to restart the session after a text is parsed. If vulnerability is still a risk, the line can be removed. It resolved my error below when I installed demo db.

Screenshot 2023-12-25 205423
HugoFara commented 11 months ago

For the SYSTEM_ADMIN_VARIABLES, I think it will be better to rewrite the portions of code concerned in a clean way, we can discuss it there: #167 .

For the TTS (Text-To-Speech) interactions, would you like to implement the new system of options? So that I can work on fixes on meantime and pull your request when it's ready.

ProgramComputer commented 11 months ago

For the SYSTEM_ADMIN_VARIABLES, I think it will be better to rewrite the portions of code concerned in a clean way, we can discuss it there: #167 .

For the TTS (Text-To-Speech) interactions, would you like to implement the new system of options? So that I can work on fixes on meantime and pull your request when it's ready.

The new way of options is added now. install.sh changes were removed too.