search

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).
https://hugofara.github.io/lwt/
The Unlicense
164 stars 19 forks source link

count quantities with mecab japanese #149

Closed ProgramComputer closed 7 months ago

ProgramComputer commented 10 months ago

Recognize quantities as words such as 二十五 or 十五 using mecab.

HugoFara commented 7 months ago

Hi @ProgramComputer ! I have reviewed and merge your commit, thanks for the PR! Just for the record, here is how LWT used to parse:

no number parsing

Here is the new result:

japanese number parsing

To be honest I was aware of the issue, but did not find it concerning as numbers are roughly fifteen characters. But I was already told it existed, LUTE published the feature and now you come with a PR request so I changed my mind and I'm glad it is implemented!