Old theme and enhance Test page frontend

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).

https://hugofara.github.io/lwt/

The Unlicense

164 stars 19 forks source link

Old theme and enhance Test page frontend #154

Closed ProgramComputer closed 6 months ago

ProgramComputer commented 9 months ago

View it here https://programcomputer.github.io/lwt/docs/info.html. Floating.js is added back. Test page footer and resizing has been changed to be more responsive. Text page is not affected.

HugoFara commented 6 months ago

Hi, they are many different things in this PR, some I don't want:

Reintroducing floating: I don't see the point, I think it's distracting and not useful (it prevents reading while scrolling).
Test page resizing: both test page header and footer have very few content. I'm not sure of why you want to add the resizing option.
Test page footer: what are the changes exactly? You do not explain in your comment :no_mouth:

For now I will close as this PR affects too many things, I'm open to discuss each point separately though!

ProgramComputer commented 6 months ago

Hi, they are many different things in this PR, some I don't want:

Reintroducing floating: I don't see the point, I think it's distracting and not useful (it prevents reading while scrolling).

Test page resizing: both test page header and footer have very few content. I'm not sure of why you want to add the resizing option.

Test page footer: what are the changes exactly? You do not explain in your comment 😶

For now I will close as this PR affects too many things, I'm open to discuss each point separately though!

Did you take a look at https://programcomputer.github.io/lwt/docs/info.html? It brings more info in index.php. The footer takes up space from the dictionary iframe.

HugoFara commented 6 months ago

Did you take a look at https://programcomputer.github.io/lwt/docs/info.html?

I did, and I'm still not convinced :smile:

It brings more info in index.php.

What do you mean?

The footer takes up space from the dictionary iframe.

I'm planning to remove the top-up iframe (#166), I'm not against this change, but there will be a more foundational change so let's after that what we do...

ProgramComputer commented 6 months ago

What do you mean?

See the picture attached. This was in the original lwt.

HugoFara commented 6 months ago

I moved this information to server_data.php:

It's cleaner
It's easier to copy/paste when sending issue
We can add more information

So I removed it from the footer :smile:

ProgramComputer commented 6 months ago

@HugoFara What do you think of the header being closer?

HugoFara commented 6 months ago

Do you mean the header?