search

HugoFara / lwt

Learn languages by reading! A language learning app stemmed from Learning with Texts (LWT).
https://hugofara.github.io/lwt/
The Unlicense
168 stars 19 forks source link

Cannot edit Improved Annotated Text #193

Closed Nick0w7 closed 6 months ago

Nick0w7 commented 6 months ago

Cannot edit the annotated text when I click on edit in the Improved annotated text tab . I noticed this was necessary in order for the translations to show up when I click on "Translations" on the main reading tab.

HugoFara commented 6 months ago

Hi, thanks for the bug report. I found the solution in line 344 of inc/ajax_impr_edit_text.php (https://github.com/HugoFara/lwt/blob/832adb2b399113ca05604d2a8aeddee5f3d18882/inc/ajax_edit_impr_text.php#L344), $wid (null) should have been replaced by $str_wid (string || null).

I fixed on dev, will publish on master soon.

Nick0w7 commented 6 months ago

Hi, Thanks for the fix! By the way, do you know when we will be able to select multiple words to make an expression (like creating "word-expression") Thank you for the improvements.

HugoFara commented 6 months ago

Mutli-word creation is possible to do it with a mouse (click and maintain on a word until the rest of the sentence is lit up), but unfortunately it is not available with touch devices such as your tablet. I included details on #142, and I cannot say if or when it will be implement as it requires rewriting the interaction system.

Have a good day!