search

HugoGranstrom / nimiSlides

A Reveal.js theme for nimib for making slideshow presentations in Nim
https://hugogranstrom.com/nimiSlides
MIT License
80 stars 6 forks source link

Update reveal version (4.5.0) and add gradient background support #27

Closed svenrdz closed 1 year ago

svenrdz commented 1 year ago

Thank you for creating nimiSlides, I used it for a work presentation and loved it!

I needed a gradient background, which was added to reveal 4.4.0 iirc, I updated it to the latest version anyway. For the gradientBackground option, I didn't go with anything smart, a simple string , as it is in reveal's documentation.

PS: I tried running the PR validation tasks locally using a clean nimble installation but it didnt find nimib for both buildDocs and buildBook tasks.

HugoGranstrom commented 1 year ago

Thank you for creating nimiSlides, I used it for a work presentation and loved it!

That makes me so glad to hear, thank you! :D

I needed a gradient background, which was added to reveal 4.4.0 iirc, I updated it to the latest version anyway. For the gradientBackground option, I didn't go with anything smart, a simple string , as it is in reveal's documentation.

Awesome, thank you for your contribution! :rocket: That's a good implementation. I read through the changelogs from 4.2 to 4.5 and the only major thing that I would like to add is that they added a dracula theme. Could you add it as well to this PR? It should be as easy as adding Dracula to this enum:

https://github.com/HugoGranstrom/nimiSlides/blob/bf4bf67c45e73de971bf8ba9d6d675d5e45160be/src/nimiSlides.nim#L29

PS: I tried running the PR validation tasks locally using a clean nimble installation but it didnt find nimib for both buildDocs and buildBook tasks.

Did you only install the testDeps perhaps? Sounds like you didn't install nimiSlides and its dependencies by running nimble install or nimble install -d if you only want its depedencies (like nimib).

svenrdz commented 1 year ago

Just added Dracula as you suggested.

I think the issue came from my local nimble install somehow, I tried again on another computer today and it built both docs and book. 🤷

HugoGranstrom commented 1 year ago

Awesome, thank you for contributing! :D I'll just wait for the CI to turn green, and then I'll merge this. :rocket:

Huh, that's weird, but nimble is weird sometimes :upside_down_face: The important thing is that it worked :+1: