HugoGranstrom / nimiSlides

A Reveal.js theme for nimib for making slideshow presentations in Nim
https://hugogranstrom.com/nimiSlides
MIT License
78 stars 5 forks source link

add meta utf-8 #3

Closed pietroppeter closed 2 years ago

pietroppeter commented 2 years ago

before:

Schermata 2022-01-08 alle 14 47 34

after:

Schermata 2022-01-08 alle 14 48 53
pietroppeter commented 2 years ago

bizarrely enough if I open the html on pages (which currently does NOT have the meta utf-8) I see it fine. so this seems to affect only the local environment

HugoGranstrom commented 2 years ago

Huh, that's interesting. For locally I get the correct emoji regardless if I view the raw HTML file directly or on a server (without the meta tag, on Windows using Firefox, Chrome and Edge) 🤔

But the meta tag should of course be included, thank you 😄 Tell me when you're ready for a merge

pietroppeter commented 2 years ago

yeah usual weird web stuff. anyway it should not hurt. nothing I can think to add so you can go ahead and merge

HugoGranstrom commented 2 years ago

Haha indeed, judging from the emoji style you aren't using Windows, right? Might be that Windows is more tolerable when it comes to emojis 🤷

Thanks again, this is one small thing that easily could have made first-time users unsatisfied with the library :D

pietroppeter commented 2 years ago

Yep mentioned on commit message that it is related to the mac but I guess the messages are not very visible

HugoGranstrom commented 2 years ago

Hehe, today I learned that there may be more to the commit message than just the name of the commit 🙈🤣

pietroppeter commented 2 years ago

I think I was inspired by looking at commit guidelines in nimskull...

HugoGranstrom commented 2 years ago

Now there's something I should read :O Thanks for the reading tip :D I should really stop using VSCodium for git and learn the command line command properly 🤭